fix component update getting overriden by mixin due to not passing in the whole attrValue into buildData (fixes #3301) #3302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngokevin
force-pushed
the
fixcomponent
branch
from
d533ca9 to
1d43383
Compare
… the whole attrValue into buildData
ngokevin
force-pushed
the
fixcomponent
branch
from
1d43383 to
bc29d94
Compare
ngokevin
added a commit
to ngokevin/aframe
that referenced
this pull request
Jan 21, 2018
… the whole attrValue into buildData (aframevr#3302)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3301
Description:
Only the update value from setAttribute was being passed into buildData. Actually, we should take the combined value from setAttribute with the current attrValue cache, and pass that into buildData.
Changes proposed:
updateCachedAttrValuebeforebuildData, and use the totalthis.attrValueintobuildData.