Skip to content

raycaster fixes and perf improvements (fixes #3428, #3429) #3250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 4, 2017
Merged

raycaster fixes and perf improvements (fixes #3428, #3429) #3250

merged 5 commits into from
Dec 4, 2017

Conversation

@ngokevin
Copy link
Member

@ngokevin ngokevin commented Nov 21, 2017 •
edited
Loading

Description:

Changes proposed:

  • Fix not being able to disable raycaster.line due to update method.
  • Fix not being able to disable raycaster.line due to tick handler overriding it.
  • Fix raycaster-intersection being emitted despite no new intersections.
  • Reuse event detail objects.
@dmarcos dmarcos merged commit 9687531 into aframevr:master Dec 4, 2017
This was referenced Dec 4, 2017
Closed
Closed
Closed
@donmccurdy donmccurdy mentioned this pull request Mar 19, 2018
Closed
@Pluto8195 Pluto8195 mentioned this pull request Aug 1, 2018
Open
@darkwave darkwave mentioned this pull request Aug 6, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review

2 participants

@ngokevin @dmarcos