Skip to content

fix raycaster direction #3239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2017
Merged

fix raycaster direction #3239

merged 1 commit into from
Nov 17, 2017

Conversation

@ngokevin
Copy link
Member

@ngokevin ngokevin commented Nov 17, 2017

Description:

The raycaster direction property was a bit off. Transformations were incorrect. The raycaster is more in line with the drawn line now.

Changes proposed:

  • Use .transformDirection with the matrixWorld rather than multiplying with quaternion.
@dmarcos dmarcos merged commit b9f37c7 into aframevr:master Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review

2 participants

@ngokevin @dmarcos