-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Serve build when deving #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6c942ac
serve build vs. dist with server (fixes #282); fix Live Reloading (fi…
cvan 62afb6f
put live option in consts instead of opts for budo; also remove unnec…
mattdesl 857e29a
use boolean instead of string or numbers for options; use watchGlob
mattdesl e4d3edf
make sure watch glob is actually being used
mattdesl f9e8f31
add comment for clarity on why src/lib/etc is not needed
mattdesl e0c2fb5
Merge branch 'dev' of https://github.com/aframevr/aframe into serve-b…
mattdesl 5485036
enable live reload by default, allow user to disable
mattdesl 6d067b4
remove open/live and leave it for a different PR, update docs, use li…
mattdesl e130f55
remove open/live and leave it for a different PR, update docs, use li…
mattdesl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you have ideas of how to cleanly do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is only possibly by extending
livereload-js. Callingbudo.reload()just ends up telling the live reload server to trigger a full page reload, so it ends up affecting all open tabs on the same host + port.Maybe the
livereload-jsserver could have areloadHref(regexToMatch)function which only triggers a page reload when the client'slocation.hrefmatches the regex.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, gotcha, that's what I thought. I assume this is a valid use case others care about, but definitely not urgent IMO.