Skip to content

Make camera system aware of mixins. #3196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2017
Merged

Make camera system aware of mixins. #3196

merged 2 commits into from
Nov 1, 2017

Conversation

@delapuente
Copy link
Contributor

@delapuente delapuente commented Oct 26, 2017

Fix #3090

Prevents the camera system from taking into account a-mixin elements when
handling the active camera.
@delapuente
Make camera system aware of mixins.
222ad92 
Prevents the camera system from taking into account a-mixin elements when
handling the active camera.
ngokevin
ngokevin reviewed Oct 26, 2017
View reviewed changes
src/systems/camera.js Outdated
for (i = 0; i < cameraEls.length; i++) {
cameraEl = cameraEls[i];
if (newCameraEl === cameraEl) { continue; }
if (isMixin(cameraEl) || newCameraEl === cameraEl) { continue; }
Copy link
Member

@ngokevin ngokevin Oct 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do !cameraEl.isEntity
Copy link
Contributor Author

@delapuente delapuente Oct 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it return true for primitives also?
Copy link
Member

@ngokevin ngokevin Oct 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah.
@ngokevin ngokevin merged commit bb10959 into aframevr:master Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs changes

2 participants

@delapuente @ngokevin