Skip to content

cache font image textures for text component (fixes #3157) #3158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2017
Merged

cache font image textures for text component (fixes #3157) #3158

merged 1 commit into from
Oct 12, 2017

Conversation

@ngokevin
Copy link
Member

@ngokevin ngokevin commented Oct 11, 2017 •
edited
Loading

Description:

Changes proposed:

  • Cache that ish.
  • Remove path dep...was importing an entire Node dep 😭
@ngokevin ngokevin changed the title cache font image textures for text component Oct 11, 2017
@ngokevin ngokevin added the perf label Oct 11, 2017
@ngokevin
Copy link
Member Author

ngokevin commented Oct 12, 2017

r?@donmccurdy
@dmarcos dmarcos merged commit 19eef8a into aframevr:master Oct 12, 2017
ngokevin added a commit to chenzlabs/aframe that referenced this pull request Oct 18, 2017
@ngokevin
cache font image textures for text component (fixes aframevr#3157) (a…
dc3fc2c 
…framevr#3158)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review perf

2 participants

@ngokevin @dmarcos