Skip to content

save object allocation on look-controls.calculateDeltaRotation #3116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2017
Merged

save object allocation on look-controls.calculateDeltaRotation #3116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
save object allocation on look-controls.calculateDeltaRotation
  • Loading branch information
@ngokevin
ngokevin committed Oct 3, 2017
commit 5cf6429cbc1f0106377dea6aea571f1ebf6577d0
14 changes: 6 additions & 8 deletions src/components/look-controls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ module.exports.Component = registerComponent('look-controls', {
this.hmdEuler = new THREE.Euler();
this.position = new THREE.Vector3();
this.rotation = {};
this.deltaRotation = {};

this.setupMouseControls();
this.setupHMDControls();
Expand Down Expand Up @@ -168,7 +169,7 @@ module.exports.Component = registerComponent('look-controls', {
*/
updateOrientation: function () {
var currentRotation;
var deltaRotation;
var deltaRotation = this.deltaRotation;
var hmdEuler = this.hmdEuler;
var hmdQuaternion = this.hmdQuaternion;
var pitchObject = this.pitchObject;
Expand All @@ -188,7 +189,7 @@ module.exports.Component = registerComponent('look-controls', {
} else if (!sceneEl.is('vr-mode') || isNullVector(hmdEuler) || !this.data.hmdEnabled) {
// Mouse drag if WebVR not active (not connected, no incoming sensor data).
currentRotation = this.el.getAttribute('rotation');
deltaRotation = this.calculateDeltaRotation();
this.calculateDeltaRotation();
if (this.data.reverseMouseDrag) {
rotation.x = currentRotation.x - deltaRotation.x;
rotation.y = currentRotation.y - deltaRotation.y;
Expand All @@ -214,15 +215,12 @@ module.exports.Component = registerComponent('look-controls', {
calculateDeltaRotation: function () {
var currentRotationX = radToDeg(this.pitchObject.rotation.x);
var currentRotationY = radToDeg(this.yawObject.rotation.y);
var deltaRotation;
deltaRotation = {
x: currentRotationX - (this.previousRotationX || 0),
y: currentRotationY - (this.previousRotationY || 0)
};
this.deltaRotation.x = currentRotationX - (this.previousRotationX || 0);
this.deltaRotation.y = currentRotationY - (this.previousRotationY || 0);
// Store current rotation for next tick.
this.previousRotationX = currentRotationX;
this.previousRotationY = currentRotationY;
return deltaRotation;
return this.deltaRotation;
},

/**
Expand Down