Skip to content

Fix increasing offset when entering VR for non positional devices #3105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2017
Merged

Fix increasing offset when entering VR for non positional devices #3105

merged 2 commits into from
Oct 2, 2017

Conversation

@vincentfretin
Copy link
Contributor

@vincentfretin vincentfretin commented Oct 1, 2017

This fixes issue #3051
@vincentfretin
Copy link
Contributor Author

vincentfretin commented Oct 1, 2017

If el.getAttribute('camera').userHeight returned 0, getUserHeight() always returned DEFAULT_CAMERA_HEIGHT instead of 0.

<a-entity camera look-controls /> now renders again userHeight to 0 like it's supposed to.
@vincentfretin
Copy link
Contributor Author

vincentfretin commented Oct 1, 2017

But maybe this fix introduces a regression for #3000, @olga-microsoft can you please verify?
@ngokevin ngokevin merged commit def0b8e into aframevr:master Oct 2, 2017
@ngokevin
Copy link
Member

ngokevin commented Oct 2, 2017

thanks!
@vincentfretin
Copy link
Contributor Author

vincentfretin commented Oct 2, 2017

Ah, I just looked at it again. It doesn't fix the issue with <a-camera /> which set camera.userHeight to 1.6 by default". I still have an increasing offset. This fixes only the case where you really want a camera on the floor.
@vincentfretin vincentfretin mentioned this pull request Oct 2, 2017
Closed
@vincentfretin vincentfretin deleted the patch-10 branch October 27, 2017 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@vincentfretin @ngokevin