Skip to content

optimize wasd-controls (add early return, skip type checking) #2945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2017
Merged

optimize wasd-controls (add early return, skip type checking) #2945

merged 1 commit into from
Aug 9, 2017

Conversation

@ngokevin
Copy link
Member

@ngokevin ngokevin commented Aug 8, 2017 •
edited
Loading

Description:

Shouldn't try to run any WASD controls code if we're not using WASD (e.g., in real VR).

Changes proposed:

  • Add early return to wasd-controls tick to not run updateVelocity if no keys have been pressed and no velocity to decay. Keep better track of what relevant keys have been pressed to be able to detect this.
  • Re-use object for updating position.
dmarcos
dmarcos reviewed Aug 8, 2017
View reviewed changes
src/components/wasd-controls.js Outdated
if (!velocity[data.adAxis] && !velocity[data.wsAxis]) { return; }

// Get movement vector and translate position.
currentPosition = el.object3D.position;
Copy link
Member

@dmarcos dmarcos Aug 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep using getAttribute to keep using the public API instead of coupling with the internals. I don't think there's any difference.
@dmarcos dmarcos merged commit 5010ad6 into aframevr:master Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review

2 participants

@ngokevin @dmarcos