Skip to content

fix missing detail property in a-scene onVRPresentChange #2920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2017
Merged

fix missing detail property in a-scene onVRPresentChange #2920

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e1af5a
fix missing detail property in a-scene onVRPresentChange
hapticdata Aug 1, 2017
0c56937
fix onVRPresentChange to check event and event.detail for display
hapticdata Aug 1, 2017
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix missing detail property in a-scene onVRPresentChange
  • Loading branch information
@hapticdata
hapticdata committed Aug 1, 2017
commit 9e1af5ad6e01e8b8206af27a986edc7fd6c763c6
2 changes: 1 addition & 1 deletion src/core/scene/a-scene.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ module.exports.AScene = registerElement('a-scene', {
onVRPresentChange: {
value: function (evt) {
// Entering VR.
if (evt.display.isPresenting) {
if (evt.detail.display.isPresenting) {
this.enterVR(true);
return;
}
Expand Down