Skip to content

when selecting element by id in selectorParse, use getElementById instead of querySelector for better performance #2820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 26, 2017
Merged

when selecting element by id in selectorParse, use getElementById instead of querySelector for better performance #2820

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f1271fc
when selecting element by id in selectorParse, use getElementById ins…
eminaz Jun 25, 2017
6d3d2ba
when selecting element by id only, use getElementById in selectorParse
eminaz Jun 25, 2017
76dba27
lint minor
eminaz Jun 26, 2017
10bd9d8
fix the regex check to see if the query is for selecting element by i…
eminaz Jun 26, 2017
48b0779
fix selectorParse regex and add tests
ngokevin Jun 26, 2017
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix the regex check to see if the query is for selecting element by i… 
…d only in queryParser
  • Loading branch information
@eminaz
eminaz committed Jun 26, 2017
commit 10bd9d8e1ed54f08debf8defa1f8783fd9010235
2 changes: 1 addition & 1 deletion src/core/propertyTypes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ function numberParse (value) {
function selectorParse (value) {
if (!value) { return null; }
if (typeof value !== 'string') { return value; }
if (value[0] === '#' && !/[.,[: ]/.test(value)) {
if (value[0] === '#' && !/[,> ]/.test(value)) {
// when selecting element by id only, use getElementById for better performance
return document.getElementById(value.substring(1));
}
Expand Down