Skip to content

fix case if text data is updated while font is loading (#2808) #2814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2017
Merged

fix case if text data is updated while font is loading (#2808) #2814

merged 1 commit into from
Jun 23, 2017

Conversation

@ngokevin
Copy link
Member

@ngokevin ngokevin commented Jun 23, 2017

Description:

What was happening:

  1. Text component initializes.
  2. Text component sets to load font.
  3. Tick function tries to change text value, but font not loaded so nothing happens.
  4. Font loads.
  5. Tick function tries to change text value, but since the data did not change from step 3, nothing ever happens no matter how many ticks.

Changes proposed:

  • Reference self for the component rather than referencing old data in case it changes.
@dmarcos
Copy link
Member

dmarcos commented Jun 23, 2017

Any test we can add?
@ngokevin
Copy link
Member Author

ngokevin commented Jun 23, 2017

Added
@dmarcos dmarcos merged commit 60a440c into aframevr:master Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review

2 participants

@ngokevin @dmarcos