fix vive-controls button colors #2772
Conversation
| this.onButtonChanged = bind(this.onButtonChanged, this); | ||
| this.onButtonDown = function (evt) { self.onButtonEvent(evt.detail.id, 'down'); }; | ||
| this.onButtonUp = function (evt) { self.onButtonEvent(evt.detail.id, 'up'); }; | ||
| this.onButtonTouchStart = function (evt) { self.onButtonEvent(evt.detail.id, 'touchstart'); }; |
There was a problem hiding this comment.
the touchpad is capacitive. Are those events not captured anymore with this PR?
There was a problem hiding this comment.
Hmm, I can adjust to make this continue to emit the trackpadtouchend events...but I just realized maybe the deeper issue is that doing triggerdown/triggerup causes a touchend event from tracked-controls.
There was a problem hiding this comment.
It might not be a bug. I think those touchstart / touchend are legit. I believe @machenmusik observed that for the first time and probably related to this https://bugzilla.mozilla.org/show_bug.cgi?id=1353523. A slight press on the trigger is considered as a touchstart event.
There was a problem hiding this comment.
For me, it takes more than a light touch. But I updated the PR to ignore the touch events for buttons that don't have touch. trackpadtouchstart and vice-versa now continue to emit.
There was a problem hiding this comment.
Coming to this a little late, but IIRC for Vive, the touch start / end events were intentional for analog buttons (trigger) as well as real touch sensitive buttons (trackpad) but are not useful for digital buttons (grip, menu).
3 participants
Description:
When Vive button was pressed, it would do:
Vive buttons don't have capacitive touch, remove touch-related handlers.
Changes proposed: