-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
[material] Add metalnessMap and roughnessMap. #2722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Could we have at least a working sample as part of the aframe examples? |
|
@cvan Why are labels being created? |
If we plan to merge this, sure. But mostly I just wanted to add context to the discussion in #2709. Do we want to support this? |
|
I don't have a strong opinion. Have we seen much demand besides the people involved in #2709? |
|
No, none actually. |
|
Will close this, and re-open if we come to another conclusion in the issue. |
|
Re-opening. I think it may be better and less surprising to just match the available parameters of MeshStandardMaterial and make this available for users working with OBJs. |
I'm inclined to say this feature should be available but not advertised in its own example. |
|
@donmccurdy What do we do with this? |
|
I'd vote to merge it, for parity with MeshStandardMaterial. Users could create an OBJ in any program, texture it in Substance Painter, and wire up their metal/rough textures with the |
|
Thanks! |
Fixes #2709.
But, maybe this needs more discussion. See #2721.
mesh.material. That probably just means I exported the texture wrong (I suck at Substance Painter) but it would be nice if someone could verify with a known-correct texture.All in all, mixed feelings about whether these more advanced textures should be in the
materialcomponent or just left to three.js loaders. Documenting good export processes for well-defined model formats is hard enough. 🙃metal-rough-cube.zip