Skip to content

try to fix intermittent material tests failures #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2017
Merged

try to fix intermittent material tests failures #2684

merged 1 commit into from
May 19, 2017

Conversation

@ngokevin
Copy link
Member

@ngokevin ngokevin commented May 19, 2017 •
edited
Loading

Description:

Tried a few things. Let's see if it works consistently. Will restart the build a few times.

Changes proposed:

  • Clean up isIOS change.
  • Remove the video at end of HLS test.
  • Don't set video src in HLS test.
  • Have loadeddata event check if material component is still there.
@ngokevin ngokevin merged commit 4dbd6fd into aframevr:master May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@ngokevin