Skip to content

Conversation

@ngokevin
Copy link
Member

@ngokevin ngokevin commented Apr 5, 2017

Description:

We use the console library debug. On each log, it appends a millisecond diff from the previous log. If an error/warning/log repeats, then the browser won't be able to collapse all the logs into one line in the console, spamming it.

I've removed the diff logic on my fork, shaving some bytes in the process. If you do var warn = AFRAME.utils.debug('hey:warn'); while (1) { warn('hey'); } in the console, the browser will now know it's repeated.

Changes proposed:

@dmarcos
Copy link
Member

dmarcos commented Apr 5, 2017

Should we move the fork to the aframevr org like the webvr-polyfill

@ngokevin
Copy link
Member Author

ngokevin commented Apr 5, 2017

I'd just keep it because we won't need to maintain it in the future or need to show it. Just pointing to a tiny patch I put on top of it.

@dmarcos dmarcos merged commit 8cb4396 into aframevr:master Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants