Skip to content

fix duplicate asset requests (fixes #2472) #2544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 4, 2017
Merged

fix duplicate asset requests (fixes #2472) #2544

merged 3 commits into from
Apr 4, 2017

Conversation

@ngokevin
Copy link
Member

@ngokevin ngokevin commented Apr 4, 2017 •
edited
Loading

Description:

One image was causing three requests:

  1. <img> in <a-assets>.
  2. Again if crossorigin wasn't set and A-Frame set it for you + re-requested.
  3. three.js TextureLoader

Changes proposed:

  • Pass <img> element through all the way down to the Texture creation process so that three.js TextureLoader doesn't get called. All the way down, we handle string (inline URLs) vs. element (<a-assets>).
  • Store <img> element in THREE.Cache if we use <a-assets> so three.js doesn't ever re-fetch.
  • Start enforcing crossorigin on images because else A-Frame will have to make a second request with the crossorigin flag set if it's not set.
  • Set crossOrigin on the TextureLoader just in case, we had some reports of it not working for inline URLs
  • tests
@machenmusik
Copy link
Contributor

machenmusik commented Apr 4, 2017

(sounds like images will work more like canvas and video now)
@ngokevin ngokevin changed the title [wip] fix duplicate asset requests (fixes #2472) Apr 4, 2017
This was referenced Apr 4, 2017
Closed
Closed
@dmarcos dmarcos merged commit 16679ab into aframevr:master Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review

3 participants

@ngokevin @machenmusik @dmarcos