Skip to content

Fix isCoordinate by successfully matching numbers with e-notation #2475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2017
Merged

Fix isCoordinate by successfully matching numbers with e-notation #2475

merged 1 commit into from
Mar 9, 2017

Conversation

@seanlerner
Copy link
Contributor

@seanlerner seanlerner commented Mar 9, 2017

When I rotate an entity it sometimes comes back with an e-notation number. For example, the number coming back was:

-71.99999999999999 62.074139506678954 -1.5056867448590336e-22

This number isn't recognized by isCoordinate and my entity would disappear.

I've modified the regex pattern to successfully match a number with e-notation.
@ngokevin ngokevin merged commit fd764d0 into aframevr:master Mar 9, 2017
@ngokevin
Copy link
Member

ngokevin commented Mar 9, 2017

Thanks!
@seanlerner
Copy link
Contributor Author

seanlerner commented Mar 9, 2017 •
edited
Loading

You're welcome :)
@ngokevin ngokevin mentioned this pull request May 23, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@seanlerner @ngokevin