Fixes #2470 Added timer #2471
Fixes #2470 Added timer #2471
Conversation
src/utils/index.js
Outdated
|
|
||
| var warn = debug('utils:warn'); | ||
|
|
||
| module.exports.Timer = require('./timer'); |
There was a problem hiding this comment.
done, I didn't noticed O:)
There was a problem hiding this comment.
@dmarcos this was my first try, but the current implementation it's quite ugly (https://github.com/mrdoob/three.js/blob/master/src/core/Clock.js) you need to call getElapsedTime() and getDelta() but you'll get different values as it will call performance.now() again. Or you call getDelta() and then access elapsedTime that doesn't seems very coherent.
Also it works with seconds instead of ms, so we need to multiply everything by 1000.
I would better stick for now with our implementation and probably open a PR in three.js but I guess it's widely used so it will break many things if we change the implementation a lot.
|
|
||
| this.animationFrameID = effect.requestAnimationFrame(this.render); | ||
| effect.render(this.object3D, this.camera); | ||
| this.time = time; |
There was a problem hiding this comment.
I'd keep the time property on the scene.
There was a problem hiding this comment.
Umm do you want it even if it's accesible with this.timer.ellapsedTime?
There was a problem hiding this comment.
Yeah, it's documented, might be being used. And if browsers ever fix the behavior, it's possible we might revert?
src/core/scene/a-scene.js
Outdated
| var effect = this.effect; | ||
| var timeDelta = time - this.time; | ||
| this.timer.update(); | ||
| var time = this.timer.elapsedTime; |
There was a problem hiding this comment.
Don't need intermediate vars, only used once.
src/utils/timer.js
Outdated
| this.running = true; | ||
| }, | ||
|
|
||
| update: function () { |
fernandojsg
force-pushed
the
timer
branch
2 times, most recently
from
b2c95c1 to
9ed44ce
Compare
|
r+ from me |
|
Test added, I'm using right now |
|
Thanks! |
|
waiting for tests |
4 participants
Introducing a timer to fix the problems with the
requestAnimationFrame