Add correct vrDisplay.isConnected check to checkHeadsetConnected() #2427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarcos
requested changes
Feb 23, 2017
src/utils/device.js
Outdated
| */ | ||
| function checkHeadsetConnected () { | ||
| var vrDisplay = controls.getVRDisplay(); | ||
| if (vrDisplay && vrDisplay.isConnected) { return vrDisplay.isConnected; } |
Member
There was a problem hiding this comment.
Can we do? if (vrDisplay && vrDisplay.isConnected) { return true; }
There was a problem hiding this comment.
can't isConnected be false, though?
should this be
if (vrDisplay && 'isConnected' in vrDisplay) { return vrDisplay.isConnected; }
Member
There was a problem hiding this comment.
Can we change to 'isConnected' in vrDisplay and it looks good.
Fixes #2426 Microsoft Edge doesn't report HMD orientation before requestPresent (for privacy reasons) which causes checkHeadsetConnected() to always return false
Contributor
Author
|
done |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2426
Microsoft Edge doesn't report HMD orientation before requestPresent (for privacy reasons) which causes checkHeadsetConnected() to always return false; on Microsoft Edge, the 'Enter VR' button falls back to the fullscreen experience, and the content is not rendered in the HMD.
Fix it is to add a vrDisplay.isConnected check (if available) to get the correct answer from hardware.