Skip to content

Prevent infinite recursion when an object with a self reference it's … #2406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2017
Merged

Prevent infinite recursion when an object with a self reference it's … #2406

merged 1 commit into from
Feb 25, 2017

Conversation

@dmarcos
Copy link
Member

@dmarcos dmarcos commented Feb 16, 2017 •
edited
Loading

…compared with itself through deepEqual

This manifested during a-saturday-night development. If we have a schema of the following form:

{
...
el: { type: 'selector' }
...
}

We end up on an infinite recursion on deepEqual when doing:

el.setAttribute('myComponent', 'el', "#entityId");
el.setAttribute('myComponent', 'el', "#entityId");

the element #entityId will be passed to deepEqual(entityIdEl, entityIdEl). Entity components hold references to the entity element creating a circular reference preventing deepEqual to find a stop condition.
@ngokevin ngokevin merged commit d8e3977 into master Feb 25, 2017
@ngokevin ngokevin deleted the fixDeepEqual branch February 25, 2017 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review

3 participants

@dmarcos @ngokevin