Skip to content

Correctly remove the loading message while injecting inspector #2380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2017
Merged

Correctly remove the loading message while injecting inspector #2380

merged 1 commit into from
Feb 13, 2017

Conversation

@fernandojsg
Copy link
Member

@fernandojsg fernandojsg commented Feb 13, 2017

Currently aframe throws an error when injecting the inspector:

Uncaught DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.
    at i.hideLoader (https://aframe.io/aframe/dist/aframe-master.min.js:198:1434)
    at HTMLScriptElement.AFRAME.INSPECTOR.AFRAME.inspectorInjected.e.onload (https://aframe.io/aframe/dist/aframe-master.min.js:198:1838)

As the inspector component adds the loading message as a child of body but tries to delete it as a child of el.

I believe it should fix aframevr/aframe-inspector#446
@fernandojsg fernandojsg mentioned this pull request Feb 13, 2017
Closed
@dmarcos dmarcos merged commit 9566a14 into aframevr:master Feb 13, 2017
@fernandojsg fernandojsg deleted the removeLoading branch March 14, 2017 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review

2 participants

@fernandojsg @dmarcos