Skip to content

fix iOS version test #2352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2017
Merged

fix iOS version test #2352

merged 2 commits into from
Feb 7, 2017

Conversation

@nullcode
Copy link
Contributor

@nullcode nullcode commented Feb 6, 2017 •
edited
Loading

Description:
Fixes #2008

The blurry effect from #2008 was actually caused by incorrectly setting BUFFER_SCALE to 0.5 even on iOS 10.

Changes proposed:

  • The workaround was created to fix webvr-polyfill/issues/102, however they PRed a different solution for it since, so this workaround in aframe might not be needed at all (haven't tested).
@nullcode nullcode mentioned this pull request Feb 6, 2017
Closed
@dmarcos
Copy link
Member

dmarcos commented Feb 6, 2017

Nice! Thanks for investigating. I'm going to do some testing on my side
@giordyb
Copy link

giordyb commented Feb 6, 2017

Just tried master + this patch on an iPhone 7 Plus w/ iOS 10 and it does indeed fix the issue for me! Finally! thank you @nullcode
@ngokevin
Copy link
Member

ngokevin commented Feb 6, 2017

Seems the workaround is still needed, despite that issue being closed:

Ok, this is now busted if BUFFER_SCALE is not 0.5. Seems like another iOS bug, which gets resolved if you set the size of the canvas to the same thing. - boris
@ngokevin
Copy link
Member

ngokevin commented Feb 6, 2017 •
edited
Loading

Rebasing the PR, and added tests. Will merge once it's green.

Tested on iPhone 6, iOS 10.

Before

img_4573

After

img_4574
@ngokevin ngokevin force-pushed the fix-ios-version-test branch from 44346b5 to 4f397b1 Compare February 6, 2017 21:35
@ngokevin
Copy link
Member

ngokevin commented Feb 6, 2017

I actually don't see a difference on my iPhone 6, 10.1.1, even with #2345 ... perhaps it's more discernable on a Plus. I'll let @dmarcos take a final look, or @giordyb can you post before/after screenshots?
@dmarcos
Copy link
Member

dmarcos commented Feb 7, 2017 •
edited
Loading

It does the trick for me on an iphone 7 Plus:

Before

img_3332

After

img_3331
@dmarcos dmarcos merged commit 8d283ee into aframevr:master Feb 7, 2017
@Stefie Stefie mentioned this pull request Feb 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review

4 participants

@nullcode @dmarcos @giordyb @ngokevin