Skip to content

Bump Three.js to r83 #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 26, 2016
Merged

Bump Three.js to r83 #2214

merged 1 commit into from
Dec 26, 2016

Conversation

@takahirox
Copy link
Collaborator

@takahirox takahirox commented Dec 26, 2016

Description:

This PR updates Three.js to r83.
It passed npm test and I confirmed examples keep working.
LMK if there's any other tests I need to check.

#2212

Changes:

  • Rename THREE.XHRLoader with THREE.FileLoader in a-assets
  • Update sound component for THREE.Audio which generates source when it starts to play in r83.
@dmarcos
Copy link
Member

dmarcos commented Dec 26, 2016

Thanks!
@dmarcos dmarcos merged commit d055cfc into aframevr:master Dec 26, 2016
@takahirox takahirox deleted the Three83 branch December 26, 2016 16:38
ngokevin pushed a commit to pulilab/aframe that referenced this pull request Feb 6, 2017
@takahirox @ngokevin
Bump Three.js to r83 (aframevr#2214)
c4554aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@takahirox @dmarcos