When updating component attrValue has to be used instead of component.data #2184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngokevin
requested changes
Dec 18, 2016
src/utils/coordinates.js
Outdated
|
|
||
| if (value && typeof value === 'object') { | ||
| return vecParseFloat(value); | ||
| coordinate = {}; |
Member
There was a problem hiding this comment.
// Fill in missing values for each vector component.
return vecParseFloat({
x: value.x || defaultVec & defaultVec.x,
// ...
});
tests/core/a-entity.test.js
Outdated
| var el = this.el; | ||
| el.setAttribute('geometry', {primitive: 'sphere', radius: 10}); | ||
| el.setAttribute('geometry', {primitive: 'box'}); | ||
| assert.deepEqual(el.components.geometry.attrValue, {primitive: 'box', radius: 10}); |
Member
There was a problem hiding this comment.
Should assert the component data as well with getAttribute.
Member
Author
There was a problem hiding this comment.
well, I should probably move this to the setAttribute suite
tests/core/a-entity.test.js
Outdated
|
|
||
| test('the attribute cache only stores the modified properties', function () { | ||
| var el = this.el; | ||
| el.setAttribute('geometry', {primitive: 'sphere', radius: 10}); |
Member
There was a problem hiding this comment.
I would assert the attrValue before the change too for clarity. Perhaps start with a box.
dmarcos
force-pushed
the
fixUpdateComponent
branch
from
3e1f3d3 to
ee8a331
Compare
dmarcos
force-pushed
the
fixUpdateComponent
branch
from
ee8a331 to
8b51f94
Compare
ngokevin
pushed a commit
to pulilab/aframe
that referenced
this pull request
Feb 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was discovered when doing:
After the first line the value of el.components.geometry.attrValue was
{primitive: box}After the update
{"buffer":true,"primitive":"sphere","skipCache":false,"depth":1,"height":1,"width":1,"segmentsHeight":1,"segmentsWidth":1,"segmentsDepth":1}causing the default values of the box primitive to be applied to the sphere primitive after update.