Skip to content

Conversation

@cvan
Copy link
Contributor

@cvan cvan commented Sep 21, 2015

No description provided.

@cvan
Copy link
Contributor Author

cvan commented Sep 21, 2015

is this clear to folks?

@cvan
Copy link
Contributor Author

cvan commented Sep 21, 2015

and perhaps I should add a comment about npm unlink

README.md Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

superfluous newline

@ngokevin
Copy link
Member

I was thinking about documenting this too, but I would have put it in vr-markup's documentation. I run npm link because I want to hack on vr-markup, not because I want to hack on vr-components.

Besides that, I would also document that the user should run both dev servers for ``vr-componentsandvr-markup`, and they should use the bundle served in memory at `http://localhost:9001/build/vr-components.js` rather than the one on the filesystem so they don't have to re-run build all the time.

README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vr-markup, not vr-components

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha, very good call

@cvan cvan self-assigned this Sep 23, 2015
@cvan cvan force-pushed the npm-link-in-README branch from d9f560e to da6de3b Compare September 23, 2015 00:46
@cvan
Copy link
Contributor Author

cvan commented Sep 23, 2015

Besides that, I would also document that the user should run both dev servers for vr-components and vr-markup, and they should use the bundle served in memory at http://localhost:9001/build/vr-components.js rather than the one on the filesystem so they don't have to re-run build all the time.

Even if just vr-components's dev server is running, the bundle gets recompiled automatically actually when the files change. Does that not happen for you?

@cvan
Copy link
Contributor Author

cvan commented Sep 23, 2015

@ngokevin: thanks for the good feedback. I've addressed everything except the most recent comment, which I just responded to.

let me know what you think.

@ngokevin
Copy link
Member

i guess so, I might've been running both just in case. Are you going to keep the link docs in this repo? I feel like it's focused on developing on markup rather than components. r+ otherwise since it's good to know how to link

@cvan cvan force-pushed the npm-link-in-README branch from da6de3b to fa49e47 Compare September 24, 2015 22:19
cvan added a commit that referenced this pull request Sep 24, 2015
document npm link commands in README
@cvan cvan merged commit 1f02a26 into master Sep 24, 2015
@cvan cvan deleted the npm-link-in-README branch November 19, 2015 21:19
cvan added a commit that referenced this pull request Nov 30, 2015
document npm link commands in README
cvan added a commit that referenced this pull request Dec 9, 2015
document npm link commands in README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants