-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
document npm link commands in README #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
is this clear to folks? |
|
and perhaps I should add a comment about |
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
superfluous newline
|
I was thinking about documenting this too, but I would have put it in Besides that, I would also document that the user should run both dev servers for ``vr-components |
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vr-markup, not vr-components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ha, very good call
d9f560e to
da6de3b
Compare
Even if just |
|
@ngokevin: thanks for the good feedback. I've addressed everything except the most recent comment, which I just responded to. let me know what you think. |
|
i guess so, I might've been running both just in case. Are you going to keep the link docs in this repo? I feel like it's focused on developing on markup rather than components. r+ otherwise since it's good to know how to link |
da6de3b to
fa49e47
Compare
document npm link commands in README
document npm link commands in README
document npm link commands in README
No description provided.