Skip to content

use default prop value if given value is empty string (fixes #2059) #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2016
Merged

use default prop value if given value is empty string (fixes #2059) #2063

merged 1 commit into from
Nov 8, 2016

Conversation

@ngokevin
Copy link
Member

@ngokevin ngokevin commented Nov 8, 2016

Description:

The schema was passing empty strings to the property type parser. For int type, this led to parseInt('', 10), which resolved to NaN. So for empty strings, we should use the default value.
@dmarcos dmarcos merged commit c1d55ec into aframevr:master Nov 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review

2 participants

@ngokevin @dmarcos