only apply user height if there is no positional tracking (fixes #1856) #2044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngokevin
force-pushed
the
userheightfix
branch
from
856d185 to
5b57098
Compare
jesstelford
added a commit
to jesstelford/hackathon-vr
that referenced
this pull request
Nov 16, 2016
See aframevr/aframe#2044 for more details.
jesstelford
added a commit
to jesstelford/virtualtour
that referenced
this pull request
Nov 16, 2016
See aframevr/aframe#2044 for more details.
jesstelford
added a commit
to jesstelford/aframe-extras
that referenced
this pull request
Nov 16, 2016
See aframevr/aframe#2044 for more details.
This was referenced Nov 16, 2016
jesstelford
added a commit
to jesstelford/APieceOfArtAsBigAsIndia
that referenced
this pull request
Nov 16, 2016
See aframevr/aframe#2044 for more details.
jesstelford
added a commit
to jesstelford/100yearsofvr
that referenced
this pull request
Nov 16, 2016
See aframevr/aframe#2044 for more details.
jesstelford
added a commit
to jesstelford/100yearsofvr
that referenced
this pull request
Nov 16, 2016
See aframevr/aframe#2044 for more details.
jesstelford
added a commit
to jesstelford/vr-visualization-experiments
that referenced
this pull request
Nov 16, 2016
See aframevr/aframe#2044 for more details.
jesstelford
added a commit
to jesstelford/Keyboard_VR
that referenced
this pull request
Nov 16, 2016
See aframevr/aframe#2044 for more details.
jesstelford
added a commit
to jesstelford/aframe-mouse-cursor-component
that referenced
this pull request
Nov 16, 2016
See aframevr/aframe#2044 for more details.
jesstelford
added a commit
to jesstelford/cityfables
that referenced
this pull request
Nov 16, 2016
See aframevr/aframe#2044 for more details.
jesstelford
added a commit
to jesstelford/kframe
that referenced
this pull request
Nov 16, 2016
See aframevr/aframe#2044 for more details.
This was referenced Nov 16, 2016
donmccurdy
pushed a commit
to c-frame/aframe-extras
that referenced
this pull request
Nov 16, 2016
See aframevr/aframe#2044 for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I tried to use the pose from VRControls, but turns out GearVR was reporting a small non-zero position (like .001, .001, .001). So I just added special cases for mobile and gear VR, and then fall back to checking the pose from the API.
Changes proposed: