Skip to content

make xhrloader public from <a-assets> (fixes #2022) #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 2, 2016
Merged

make xhrloader public from <a-assets> (fixes #2022) #2023

merged 2 commits into from
Nov 2, 2016

Conversation

@ngokevin
Copy link
Member

@ngokevin ngokevin commented Oct 28, 2016

No description provided.

@ngokevin
Copy link
Member Author

ngokevin commented Oct 31, 2016

Need to rename to fileLoader.
@dmarcos
Copy link
Member

dmarcos commented Nov 2, 2016

Should we expose this or let people use THREE.XHRLoader. We're exporting THREE in the global scope anyways. Mapping THREE.XHRLoader to our API could lead to confusion and hides what it really is. Not sure if the slightly more convenient name is worth the increase in API surface.
@dmarcos
Copy link
Member

dmarcos commented Nov 2, 2016

Disregard my previous comment. I misunderstood.
@dmarcos dmarcos merged commit 8d07b9c into aframevr:master Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review

2 participants

@ngokevin @dmarcos