Add 'position' support for Trackedcontrols #2002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarcos
reviewed
Oct 24, 2016
| var controllerEuler = new THREE.Euler(); | ||
| var controllerPosition = new THREE.Vector3(); | ||
| var controllerQuaternion = new THREE.Quaternion(); | ||
| var deltaControllerPosition = new THREE.Vector3(); |
Member
There was a problem hiding this comment.
This has been always kind of crappy. Can we create a closure and initialize and reuse these variables instead instancing once per frame? Like this:
https://github.com/aframevr/aframe/blob/master/src/components/raycaster.js#L142
Member
Author
There was a problem hiding this comment.
They're already in a closure
src/components/tracked-controls.js
Outdated
| }, | ||
|
|
||
| init: function () { | ||
| this.previousControllerPosition = new THREE.Vector3(); |
Member
There was a problem hiding this comment.
Can we move this variable to a closure as I indicated below?
fernandojsg
force-pushed
the
controllerOffset
branch
from
fd31500 to
c76944a
Compare
ngokevin
reviewed
Oct 24, 2016
| z: THREE.Math.radToDeg(controllerEuler.z) | ||
| }); | ||
|
|
||
| deltaControllerPosition.copy(controllerPosition).sub(previousControllerPosition); |
Member
There was a problem hiding this comment.
Could use a good ol' unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When developing the teleport component I noticed that you could set a
positionvalue for the camera entity when jumping to another position, but if you set apositionfor the hand controllers (to follow your head) it won't be taken into consideration when computing the position as right now this position it's just based on the current controller absolute position.Changes proposed:
positioncomponent value for each hand.