Skip to content

Add wireframe params to Flat and Standard Material #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 12, 2016
Merged

Add wireframe params to Flat and Standard Material #1971

merged 3 commits into from
Oct 12, 2016

Conversation

@AdaRoseCannon
Copy link
Contributor

@AdaRoseCannon AdaRoseCannon commented Oct 11, 2016

Description:

Moved in a couple more of the THREE.js properties WRT wireframes.

The default width is set to 2 so that it looks cleaner on VR Headsets

If there are reasons for them not being included that is fine and I just thought it could be useful.

Changes proposed:

Allow standard and flat materials to use wireframes.
@dmarcos
Copy link
Member

dmarcos commented Oct 11, 2016

Thanks! Can you update the docs too?
@AdaRoseCannon
Copy link
Contributor Author

AdaRoseCannon commented Oct 11, 2016

Just checking you were interested before tests and docs, will do them now. 😄
@ngokevin
Copy link
Member

ngokevin commented Oct 12, 2016

thanks!
@ngokevin ngokevin merged commit c5bb999 into aframevr:master Oct 12, 2016
@ngokevin ngokevin mentioned this pull request Oct 27, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review

3 participants

@AdaRoseCannon @dmarcos @ngokevin