Skip to content

Tracked controls still update the pose if a mesh is not present #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2016
Merged

Tracked controls still update the pose if a mesh is not present #1875

merged 1 commit into from
Sep 1, 2016

Conversation

@dmarcos
Copy link
Member

@dmarcos dmarcos commented Aug 31, 2016

The tick method was returning if a mesh is not defined. tracked-controls should work with any entity with and without a mesh defined.
ngokevin
ngokevin reviewed Aug 31, 2016
View reviewed changes
src/components/tracked-controls.js Outdated
var mesh = this.el.getObject3D('mesh');
if (!mesh) { return; }
if (mesh.update) { mesh.update(delta / 1000); }
// Update mesh animations;
Copy link
Member

@ngokevin ngokevin Aug 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semicolon
@ngokevin
Copy link
Member

ngokevin commented Aug 31, 2016

could add a test
@dmarcos dmarcos force-pushed the meshAnimation branch 2 times, most recently from a9fb26b to 3b0a916 Compare August 31, 2016 19:03
@ngokevin ngokevin merged commit 18314bd into aframevr:master Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review

2 participants

@dmarcos @ngokevin