Skip to content

Conversation

@Zeouterlimits
Copy link
Contributor

Description:
Issue 269

Switch to ghpages module instead of calling gh-pages directly with a custom script
(aframe-boilerplate also uses ghpages, not a custom script)

Changes proposed:

  • Delete script file
  • Add 0.0.8, latest ghpages version, as a dev dependency
  • Change command to push contents of gh-pages to user or aframe github page
Switch to ghpages module instead of calling gh-pages directly with a custom script
@dmarcos
Copy link
Member

dmarcos commented Aug 28, 2016

Is the funcionality equivalent?

@Zeouterlimits
Copy link
Contributor Author

@ngokevin
Copy link
Member

We use the ghpages script across the boilerplate, most published components in the ecosystem use it, and I use it for my projects too. So it's good, thanks!

@ngokevin ngokevin merged commit 8629436 into aframevr:master Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants