set important on canvas fullscreen style to not get overridden by webvr-polyfill #1810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| bottom: 0 !important; | ||
| z-index: 999999 !important; | ||
| position: fixed; | ||
| position: fixed !important; |
Contributor
There was a problem hiding this comment.
can you add a comment? I hope nobody needs to ever override any of these important values. perhaps these styles would be better set with a a.fullscreen.forced class? I could be wrong. I haven't touched this code in a while.
Member
Author
There was a problem hiding this comment.
Added a comment. If developers want to override, they can do <a-scene embedded> which removes these styles and allows styling of the canvas. That's also already documented.
Current coverage is 81.93% (diff: 100%)@@ master #1810 diff @@
==========================================
Files 100 100
Lines 3548 3548
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 2907 2907
Misses 641 641
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Discovered and investigated by @dmarcos