don't bind render on each tick #1808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 81.93% (diff: 66.66%)@@ master #1808 diff @@
==========================================
Files 100 100
Lines 3547 3548 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2906 2907 +1
Misses 641 641
Partials 0 0
|
src/core/scene/a-scene.js
Outdated
| this.isMobile = isMobile; | ||
| this.isScene = true; | ||
| this.object3D = new THREE.Scene(); | ||
| this.renderBinded = this.render.bind(this); |
Member
There was a problem hiding this comment.
we can just do this.render = this.render.bind(this) as we do in other modules
Member
Author
There was a problem hiding this comment.
I get a-scene.js:405 Uncaught TypeError: Cannot read property 'render' of undefined
Member
There was a problem hiding this comment.
Do you have to set writable: true in the render method?
Member
Author
|
Will fix the Codecov Travis failures soon. Need to remove the constraint that all PRs must improve coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.