don't require people to set crossorigin on assets (fixes #1775) #1789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 81.78% (diff: 71.87%)@@ master #1789 diff @@
==========================================
Files 100 100
Lines 3524 3546 +22
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2887 2900 +13
- Misses 637 646 +9
Partials 0 0
|
|
I am desperately needed to fix a cross domain issue, apparently this is not the solution, it shows the same error like before to me:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If cross-origin media element is defined in
<a-assets>withoutcrossoriginattribute set, then<a-assets>will re-append the media element withcrossoriginset to re-request with correct headers. three.js will then be able to access the contents of the resource.This means no more CORS confusions!