Skip to content

Conversation

@mkungla
Copy link
Contributor

@mkungla mkungla commented Aug 12, 2016

Test coverage is localy browsable and found in coverage/report
Added travis after_success: for posting report to codecov.

Added devDependencies,
istanbul, browserify-istanbul, codecov, karma-coverage

Updated devDependencies,
browserify: ^11.0.1 -> ^13.1.0
karma: ^0.13.15 -> 1.2.0
karma-browserify: ^4.4.0 -> ^5.1.0
karma-firefox-launcher: ^0.1.6 -> ^1.0.0
karma-mocha: ^0.2.0 -> ^1.1.1
karma-mocha-reporter: ^1.1.0 -> ^2.1.0
karma-sinon-chai: ^1.1.0 -> ^1.2.3
lolex: ^1.4.0 -> ^1.5.1
mocha: ^2.3.3 -> ^3.0.2
sinon: ^1.17.3 -> ^1.17.5

I wasn't familiar with Coveralls, so used codecov.io instead

@codecov-io
Copy link

codecov-io commented Aug 12, 2016

Current coverage is 70.95% (diff: 100%)

No coverage report found for master at ce210cb.

Powered by Codecov. Last update ce210cb...060a591

@mkungla
Copy link
Contributor Author

mkungla commented Aug 12, 2016

You can test this PR out,
Create new branch with username prefix since it is easier to remember what branch is what
git checkout -b mkungla-coverage master
Pull and merge my coverage branch
git pull https://github.com/mkungla/aframe.git coverage

now if you run tests then new directory called coverage/report is created which is static html so you can see what your test are covering.

reporters: ['mocha']
reporters: ['mocha', 'coverage'],
coverageReporter: {
dir: 'coverage',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put this in tests/coverage/?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@ngokevin
Copy link
Member

Works great!!

Marko Kungla added 2 commits August 12, 2016 18:14
Test coverage is localy browsable and found in coverage/report
Added travis after_success: for posting report to codecov.

Added devDependencies,
istanbul, browserify-istanbul, codecov, karma-coverage

Updated devDependencies,
browserify: ^11.0.1 -> ^13.1.0
karma: ^0.13.15 -> 1.2.0
karma-browserify: ^4.4.0 -> ^5.1.0
karma-firefox-launcher: ^0.1.6 -> ^1.0.0
karma-mocha: ^0.2.0 -> ^1.1.1
karma-mocha-reporter: ^1.1.0 -> ^2.1.0
karma-sinon-chai: ^1.1.0 -> ^1.2.3
lolex: ^1.4.0 -> ^1.5.1
mocha: ^2.3.3 -> ^3.0.2
sinon: ^1.17.3 -> ^1.17.5
@ngokevin ngokevin merged commit c9e9a0f into aframevr:master Aug 12, 2016
@ngokevin ngokevin added the r+ label Aug 12, 2016
@mkungla mkungla deleted the coverage branch August 12, 2016 15:55
@vincentfretin vincentfretin mentioned this pull request Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants