Skip to content

create external sourcemap for minified dist (fixes #1328) #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2016
Merged

create external sourcemap for minified dist (fixes #1328) #1746

merged 1 commit into from
Aug 9, 2016

Conversation

@ngokevin
Copy link
Member

@ngokevin ngokevin commented Aug 9, 2016 •
edited
Loading

Description:

For a proper release, provide source maps with the minified dist.

Changes proposed:

  • Use minifify to do minification with source maps
  • Add some NPM tags to add discoverability (and indexed on customelements.io)
  • Move browserify-css to devDeps since our index points to dist
@dmarcos dmarcos merged commit 33b1848 into aframevr:master Aug 9, 2016
mkungla pushed a commit to mkungla/aframe that referenced this pull request Aug 9, 2016
@ngokevin
create external sourcemap for minified dist (fixes aframevr#1328) (af…
7d8eb03 
…ramevr#1746)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review

2 participants

@ngokevin @dmarcos