Fix #798: Add 'aframe-injected' attribute to elements injected by aframe #1736
Conversation
src/systems/material.js
Outdated
| warn('`$s` is not a valid video', src); | ||
| }, true); | ||
| videoEl.src = src; | ||
| videoEl.setAttribute('aframe-injected', ''); |
There was a problem hiding this comment.
These videos are never injected to the DOM so don't need it here.
|
@fernandojsg The inspector is involved with this. Thoughts? |
darkwing
force-pushed
the
aframe-injected
branch
from
45516d2 to
c74b1fd
Compare
|
It's ok for me, as I could look for those |
darkwing
force-pushed
the
aframe-injected
branch
from
c74b1fd to
b3e9e40
Compare
|
Updated! |
|
@fernandojsg Do you want the aframe-injected also on the VR mode UI, canvas, meta tags? |
|
Yep that would be great! As right now I'm removing them by hand: |
|
@darkwing would you mind remove those as well? I think the issue was primarily for @fernandojsg's inspector to generate HTML |
darkwing
force-pushed
the
aframe-injected
branch
from
b3e9e40 to
19cbee4
Compare
|
Added to VR elements and metas, updated test. |
darkwing
force-pushed
the
aframe-injected
branch
from
19cbee4 to
a09f9a9
Compare
|
thanks! |
|
@ngokevin @darkwing ops, sorry I was a little bit late to the conversation, maybe it could be another PR, but what about including And probably for the stats too? |
4 participants
re: #798
Added as an attribute to not muddle the CSS classes, while still able to select with QSA. This also adds to only
a-elements as well as the<video>created bymaterial.js.Purposely did not add to meta tag, the original canvas, or the
vr-mode-uielements as they're simply for VR mode in/out.Let me know what you think of this.