Nits for updateStateMixins #1693
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/core/a-entity.js
Outdated
| forEach.call(stateMixinsEls, function (el) { stateMixinIds.push(el.id); }); | ||
| stateMixinIds.forEach(self.unregisterMixin.bind(self)); | ||
| // State mixins | ||
| var stateMixinsEls = Array.from(document.querySelectorAll('[id^=' + mixinId + '-]')); |
Member
There was a problem hiding this comment.
It seems that the support of Array.from is more limited than the previous form.
Contributor
Author
|
If we want to support old browsers without |
Member
|
Yes. I think we should get rid of Array.from. We can open a different PR to remove the one introduced by #1642 |
darkwing
force-pushed
the
updateStateMixins
branch
from
1ce1e5f to
a411df7
Compare
darkwing
force-pushed
the
updateStateMixins
branch
from
a411df7 to
b485ea5
Compare
Contributor
Author
|
Updated. Feel free to just close if you don't want it |
Contributor
Author
|
Closing in favor of another. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small nit to knock down code.