Skip to content

Fix #704: Add warning for use of repeat=infinite #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2016
Merged

Fix #704: Add warning for use of repeat=infinite #1640

merged 1 commit into from
Jul 19, 2016

Conversation

@darkwing
Copy link
Contributor

@darkwing darkwing commented Jul 19, 2016

Description:
Fixes #704

Changes proposed:

  • One reservation here is that the value method can get called many times and that this warning may become overwhelming. Let me know what you think.
@ngokevin ngokevin merged commit d3804bf into aframevr:master Jul 19, 2016
@ngokevin
Copy link
Member

ngokevin commented Jul 19, 2016

Thanks!

Also check out https://github.com/ngokevin/aframe-animation-component, I will be repping this implementation from now on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@darkwing @ngokevin