Skip to content

set use-credentials by default for video textures (fixes #1576) #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2016
Merged

set use-credentials by default for video textures (fixes #1576) #1598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
set use-credentials by default for video textures (fixes #1576)
  • Loading branch information
@ngokevin
ngokevin committed Jul 1, 2016
commit a995cdde7ff50e3e72d3b02ec23e278a81539815
4 changes: 2 additions & 2 deletions src/systems/material.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ function createVideoEl (src, width, height) {
videoEl.setAttribute('webkit-playsinline', ''); // Support inline videos for iOS webviews.
videoEl.autoplay = true;
videoEl.loop = true;
videoEl.crossOrigin = true;
videoEl.crossOrigin = 'use-credentials';
videoEl.addEventListener('error', function () {
warn('`$s` is not a valid video', src);
}, true);
Expand Down Expand Up @@ -304,7 +304,7 @@ function fixVideoAttributes (videoEl) {
if (videoEl.getAttribute('preload') === 'false') {
videoEl.preload = 'none';
}
videoEl.crossOrigin = true;
videoEl.crossOrigin = videoEl.crossOrigin || 'use-credentials';
// To support inline videos in iOS webviews.
videoEl.setAttribute('webkit-playsinline', '');
return videoEl;
Expand Down