Preserve old geometry metadata. #1557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/systems/geometry.js
Outdated
| if (!doBuffer) { return geometry; } | ||
|
|
||
| bufferGeometry = new THREE.BufferGeometry().fromGeometry(geometry); | ||
| bufferGeometry.oldMetadata = {type: geometry.type, parameters: geometry.parameters || {}}; |
Member
Author
There was a problem hiding this comment.
No preference – only precedent I could find for this was mesh.userData[*] but it would be a little more complicated to pass this metadata up to the Mesh probably
Member
There was a problem hiding this comment.
Was thinking we name it metadata since the data is still current, but just destroyed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1538
If we're using BufferGeometry instead of BoxBufferGeometry / PlaneBufferGeometry (not sure what the performance implications are on that switch), it would be helpful to preserve some of the metadata. For example, I use this to construct CANNON.Shape instances from the geometry.