setActiveCamera: call play() and modified camera-set-active event
#1502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #1500: Calls
play()when we change the active camerathis.activeCameraEl.play();so it activates the controls attached to the camera (eg:look-controls)I've also moved the emission of the
camera-set-activeto the end of the function. In the editor for example I was listening to that event to check if you've added a new camera so I could save it for later but switch automatically to the editor camera. The problem is that the event was emitted and after all the other cameras (including the one I wanted to set in the event) were deactivated.So by just moving the event to the end you ensure that you've already a consistent state for all the cameras in the scene and you can do whatever you want like, in my case, switching to another default camera.