Skip to content

Conversation

@msimpson
Copy link
Contributor

@msimpson msimpson commented May 12, 2016

This needs review as I had to alter the prototype to use defaultComponentsFromPrimitive in registerPrimitive instead of simply defaultComponents since Object.create will override the defaultComponents from the a-entity prototype. This, if allowed, would cause test failures as getAttribute subsequently returns null for those overridden attributes (i.e. position, scale, etc.).

Fixes #1330.

@dmarcos
Copy link
Member

dmarcos commented May 12, 2016

It looks good to me. I let @ngokevin merge it.

@ngokevin ngokevin merged commit 91a8504 into aframevr:master May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants