basic text support #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/vr-text.js
Outdated
Member
There was a problem hiding this comment.
Can people use styles on the element to override this?
Contributor
There was a problem hiding this comment.
yeah, I would add these styles to our stylesheet, so the styles can get overridden without doing !important by the user
added 2 commits
September 21, 2015 12:24
Contributor
|
looks good! file-up issues would be great 👍 |
cemkod
pushed a commit
to cemkod/aframe
that referenced
this pull request
Dec 23, 2015
Fixed nested iframe web element find
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
review? @cvan