fix unhandled edge cases for keyboard shortcuts (fixes #927, fixes #932, fixes #1063) #1211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Returns whether we can safely listen to this keyboard event. | ||
| * @returns {Boolean} True if we can. | ||
| */ | ||
| module.exports.shouldCaptureKeyEvent = function (event) { |
Contributor
Author
Member
|
@cvan What's the state of this. Is this ready to go? Let's use the |
| // Keyboard events | ||
| window.addEventListener('keydown', this.onKeyDown, false); | ||
| window.addEventListener('keyup', this.onKeyUp, false); | ||
| window.addEventListener('blur', this.onBlur); |
Member
There was a problem hiding this comment.
Should we also have a listener for the symmetric event. window.addEventListener("focus", this.onFocus);?
Contributor
Author
There was a problem hiding this comment.
oh, very good call.
hmm, the more I think about it we probably shouldn't call pause on blur because that removes the event listeners. and then we'd have to reattach them when play gets called on focus. seems like maybe a waste. thoughts?
Contributor
Author
|
@dmarcos updated to handle blur/focus/visibilitychange pause/play correctly. good catch, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.