Block Form Handling #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fosterbrereton
commented
Feb 2, 2024
| attribute_sequence attributes; | ||
| std::tie(die, attributes) = abbreviation_to_die(_s.tellg(), process_mode::complete); | ||
|
|
||
| #if ORC_FEATURE(TRACY) |
Contributor
Author
There was a problem hiding this comment.
squelch a warning.
leethomason
approved these changes
Feb 2, 2024
Contributor
leethomason
left a comment
leethomason
left a comment
There was a problem hiding this comment.
Looks good & good find.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
blockNform handling to the DWARF processor.Until now, we haven't found a case in the wild where essential DWARF data was encoded using one of the
blockNforms. Today such an example arose. This will handle up to 8 bytes of arbitrary block data, and assumes the result is a 64-bit unsigned value.