Hotfixes

[bheath-adobe]

Description

Hotfixes:

• Fix for reading correct ref_addr in dwarf v2.
• Workaround for only reading partial decl_files list.
• Fix issue with tests not recognizing failed compilations.

Related Issue

#67

Motivation and Context

Workaround for issue.

How Has This Been Tested?

Tests passing.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[fosterbrereton]

This comment about declaration is no longer relevant. I had to pull it from the skip_die portion of the code, but forgot about this comment. can you remove it? I am not sure what to do about the re-introduction of the declaration here as part of the die_hash. Thoughts?

[bheath-adobe]

So, put it back to how it was a while ago?

bool is_declaration =
        attributes.has_uint(dw::at::declaration) && attributes.uint(dw::at::declaration) == 1;

and include is_declaration in the hash?

[fosterbrereton]

I have consolidated the calls into a new has_flag_attribute as I am using it elsewhere. So in the hash you can just include has_flag_attribute(attributes, dw::at::declaration).

[fosterbrereton]

These changes LGTM Brandon! Thank you for them. If you decide not to touch the declaration comment that's fine - I can clean it up in a subsequent PR.