hotfixes #65
Merged
hotfixes #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leethomason
reviewed
Jan 5, 2024
Contributor
leethomason
left a comment
leethomason
left a comment
There was a problem hiding this comment.
Just one check in there. Nice set of fixes!
|
|
||
| std::size_t size() const { return _l - _p; } | ||
| std::size_t size() const { | ||
| assert(*this); |
Contributor
There was a problem hiding this comment.
Checking: did you mean *this or this or this && *this
Contributor
Author
There was a problem hiding this comment.
I do mean *this. Because it is in an assert clause, that will require the compiler convert the expression to a boolean value. freader has an explicit operator bool that allows freader to convert to a boolean operation, and does so by performing a couple of checks to make sure the internal state of the instance is valid. So by writing assert(*this), we are asserting some necessary validity checks for pre/postconditions on a handful of the freader APIs.
leethomason
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple hotfixes.
Description
freaderdie_hashto be more accurate about what it includes when computing the die's hash.evaluate_exprlocblockform handling. By "better" I mean we now throw an error if we see it, instead of treating it like anexprloc, which was definitely not right. I am working off of the hunch that an attribute that has ablockform will not contribute to an ODR. I have added an exception in case such an attribute is encountered, at which point we'll likely need an expensive fix.const_valueto the list of nonfatal attributes.